Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Ember addon #210

Closed
Turbo87 opened this issue May 27, 2017 · 2 comments
Closed

Convert to Ember addon #210

Turbo87 opened this issue May 27, 2017 · 2 comments
Labels
internal

Comments

@Turbo87
Copy link
Member

Turbo87 commented May 27, 2017

right now the integration of this package into ember-qunit and ember-mocha is a little messy. IMHO we should convert this into a real addon to make the build code less complex and error prone.

/cc @rwjblue @trentmwillis
@trentmwillis
Copy link
Member

Totally agree. I think it also would lower the barrier for new contributors.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 7, 2017

resolved by #213

@Turbo87 Turbo87 closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Turbo87 @trentmwillis