You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #10268 was merged, there was a change in the way route-recognizer is built, which uses a similar string replacement to add its RouteRecognizer.VERSION number property but since emberjs-build consumes the package via bower as an ES6 module, it doesn't get that chance and is instead replaced with ember's VERSION.
For anyone interested in working on this, here is a rough outline of what needs to change:
route-recognizer needs to generate a dist/es6/ folder that contains the preprocessed ES6 (aka version string is replaced). This should be part of the prepublish script.
update emberjs-build to pull route-recognizer from NPM, and use the dist/es6 as the source tree (instead of bower_components)
This is how HTMLBars is pulled in (and works well).
Since #10268 was merged, there was a change in the way route-recognizer is built, which uses a similar string replacement to add its
RouteRecognizer.VERSION
number property but since emberjs-build consumes the package via bower as an ES6 module, it doesn't get that chance and is instead replaced with ember'sVERSION
.Though we don't believe any internal code depends on this version being correct...it's clearly wrong...so probably should fix it some how.
Change can be found here: tildeio/route-recognizer@8e1058e...404b848#diff-3cd8d4dfb826ed2ebdceb9c43e729d8eR534
The text was updated successfully, but these errors were encountered: