Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteRecognizer.VERSION is incorrectly set to ember's version #10269

Closed
jayphelps opened this issue Jan 22, 2015 · 1 comment · Fixed by #10280
Closed

RouteRecognizer.VERSION is incorrectly set to ember's version #10269

jayphelps opened this issue Jan 22, 2015 · 1 comment · Fixed by #10280

Comments

@jayphelps
Copy link
Contributor

Since #10268 was merged, there was a change in the way route-recognizer is built, which uses a similar string replacement to add its RouteRecognizer.VERSION number property but since emberjs-build consumes the package via bower as an ES6 module, it doesn't get that chance and is instead replaced with ember's VERSION.

RouteRecognizer.VERSION = '1.11.0-beta.1+canary.6f7b1c48';

Though we don't believe any internal code depends on this version being correct...it's clearly wrong...so probably should fix it some how.

Change can be found here: tildeio/route-recognizer@8e1058e...404b848#diff-3cd8d4dfb826ed2ebdceb9c43e729d8eR534

@rwjblue
Copy link
Member

rwjblue commented Jan 23, 2015

For anyone interested in working on this, here is a rough outline of what needs to change:

  • route-recognizer needs to generate a dist/es6/ folder that contains the preprocessed ES6 (aka version string is replaced). This should be part of the prepublish script.
  • update emberjs-build to pull route-recognizer from NPM, and use the dist/es6 as the source tree (instead of bower_components)

This is how HTMLBars is pulled in (and works well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants