-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider components with a / (and no -) in their name to be valid. #10407
Comments
This should "just work" with Ember 1.9 and above. |
That's curious, how would the ES6 resolver know where to look for a component in a sub folder? I thought the pods and otherwise functioned by having predictable structures. Edit: I too would love this feature. We have 30 components currently. And when we replace itemControllers with components we'll have about 50. |
I'm also unable to get this to work. Do you still need a dasherized name when a component is nested? For example will moving a Edit: It seems to be the combination of the component pod structure and the nested nature. This structure:
throws an unfound helper error when using |
Working fine for me. You do still need a dasherized name. |
Made a demo repo. See this commit: rwjblue/components-in-subdirs@2109939 |
I had the same concern, but @nathanpalmer kindly explained that this is not an issue at all. |
@lolmaus Yea given that the subdirectory is part of the name that makes sense. One thing I'm still curious about is how this will play out once HTMLBars has shed it's Handlebars templates. Will the following just keep working? <subdir1/template-only random-string="something passed in the application.hbs">
</subdir1/template-only> |
Yes. Also, htmlbars will not stop allowing the usage of mustaches. You will likely always use curlies for things like '{{if}}', '{{each}}', etc. |
@rwjblue Hey thanks for the quick reply! |
@rwjblue I think you misunderstood. I would like to consider |
@tim-evans - Interesting idea. Flagging for discussion at the next core team meeting... |
Thanks! :3 |
i like this |
As do I. |
Seems like this might already be partially supported.
|
@nathanpalmer nope, not yet
|
basically this boils down to |
This is a pain point with code organization on our app. We currently have 90 component definitions in
/components
, and I would like to push some of these components into a folder for organizational purposes.For a small sample, we have
artwork-weight
,artwork-piece
,artwork-image
,artwork-dimensions
,artwork-image-approver
, as components organized under the artwork vertical.I'm also willing to hear other organizational strategies (like pods), but I'll need some guidance, and I'm hesitant to move to pods unless there are major positives to this.
For current info on our app, we're on 1.8, upgrading to canary and running on ember-cli
I've been working also on refactoring our application in the process of upgrading to canary, since we were using workarounds and patterns that are no longer supported.
Thanks!
The text was updated successfully, but these errors were encountered: