Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input helper valueBinding not updated #10541

Closed
ilkkao opened this issue Feb 26, 2015 · 4 comments · Fixed by #10544
Closed

Input helper valueBinding not updated #10541

ilkkao opened this issue Feb 26, 2015 · 4 comments · Fixed by #10544

Comments

@ilkkao
Copy link
Contributor

ilkkao commented Feb 26, 2015

This code stopped working recently:

http://jsbin.com/cosogimulu/1/edit?html,js,output

Regression caused by #10525?
@ilkkao
Copy link
Contributor Author

ilkkao commented Feb 26, 2015

I checked that before #10525 it was possible to use this.set('message', '') unlimited times to clear the user entered value.

@raytiley
Copy link
Contributor

I'll take a look at this in a few hours as I'm the one that broke it. :(

@raytiley
Copy link
Contributor

Pretty sure I know what this will write a test and submit a patch in a bit.

@raytiley raytiley mentioned this issue Feb 26, 2015
Merged
@ilkkao
Copy link
Contributor Author

ilkkao commented Feb 26, 2015

nice!, thanks @raytiley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX beta] update lastValue of AttrNode even when not rerendering raytiley/ember.js
2 participants
@raytiley @ilkkao