Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ember.View support when not using ember-legacy-views addon. #11775

Closed
12 tasks done
rwjblue opened this issue Jul 16, 2015 · 8 comments
Closed
12 tasks done

Remove Ember.View support when not using ember-legacy-views addon. #11775

rwjblue opened this issue Jul 16, 2015 · 8 comments
Labels

Comments

@rwjblue
Copy link
Member

rwjblue commented Jul 16, 2015

@rwjblue
Copy link
Member Author

rwjblue commented Jul 16, 2015

I believe that @martndemus was interested in this one...

@ghost
Copy link

ghost commented Jul 16, 2015

ITS A TRAP

@rwjblue
Copy link
Member Author

rwjblue commented Jul 16, 2015

CONFIRM

@ghost
Copy link

ghost commented Jul 17, 2015

Hiding Ember.View behind a feature flag is easy. Finding a way to reload Ember with a feature flag enabled seems impossible. How was this done with other feature flags?

@ghost
Copy link

ghost commented Jul 18, 2015

CELEBRATION

@mixonic
Copy link
Member

mixonic commented Jul 20, 2015

well done

@rwjblue
Copy link
Member Author

rwjblue commented Jul 25, 2015

This was all fixed by @martndemus a few days.

@rwjblue rwjblue closed this as completed Jul 25, 2015
@justinaray
Copy link

I came across this when I finally got around to upgrading my app to 2.0. I was surprised to find that the deprecation is listed as until: 2.4 but that you need the ember-legacy-views addon to actually utilize the deprecated classes, etc.

If someone is filtering out only 2.0 deprecations to make the jump, they could easily miss View-based deprecations. Even worse if they missed the blog post and didn't know about the addon.

Sorry to comment on an old issue, but didn't know if this should be a new issue or added here. Happy to open an issue and/or PR if you think it worthwhile.

Despite a little confusion with this one, feature-flag deprecations FTW!!! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants