Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagless components issue on beta and canary #12554

Closed
mike183 opened this issue Nov 4, 2015 · 7 comments
Closed

Tagless components issue on beta and canary #12554

mike183 opened this issue Nov 4, 2015 · 7 comments
Labels

Comments

@mike183
Copy link
Contributor

mike183 commented Nov 4, 2015

A TypeError is triggered when attempting to use a tagless component, although it only seems to occur when the component has no JS file. Creating a JS file for the component makes the issue disappear.

The issue seems to have been introduced in this PR: #12503

Error:
Uncaught TypeError: Cannot read property 'lookup' of undefined

Twiddle showing error (No JS file):
https://ember-twiddle.com/aeb614b5b753fd9f562c

Twiddle with no error (Includes JS file):
https://ember-twiddle.com/33793eecdd0026d524a1

@tim-evans
Copy link
Contributor

Found this as well. It seems that the owner property on the RenderEnv isn't being set for tests.

@tim-evans
Copy link
Contributor

I've tracked it down to 9845a9a. Tests pass before this commit and fail afterwards. It may be that https://github.com/switchfly/ember-test-helpers/tree/master/lib/ember-test-helpers needs an update to handle this. (I'm not sure).

@tim-evans
Copy link
Contributor

See #12555 for the checklist of this feature.

@rwjblue
Copy link
Member

rwjblue commented Nov 5, 2015 via email

@tim-evans
Copy link
Contributor

Super! Anything I can do to help with this @rwjblue ?

@tim-evans
Copy link
Contributor

The following configuration should fix this:

package.json

  "ember-cli-qunit": "0.3.14"

bower.json

  "ember": "ember#canary",
  "ember-data": "ember-data#canary"

@rwjblue
Copy link
Member

rwjblue commented Nov 11, 2015

Ok, closing for now.

@rwjblue rwjblue closed this as completed Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants