-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagless components issue on beta and canary #12554
Comments
Found this as well. It seems that the |
I've tracked it down to 9845a9a. Tests pass before this commit and fail afterwards. It may be that https://github.com/switchfly/ember-test-helpers/tree/master/lib/ember-test-helpers needs an update to handle this. (I'm not sure). |
See #12555 for the checklist of this feature. |
It seems that the owner property on the RenderEnv isn't being set for tests.
Yes, ember-test-helpers definitely needs a few tweaks to work with canary, but the `owner` issue should not affect the beta branch (which is also demonstrating the issue).
|
Super! Anything I can do to help with this @rwjblue ? |
The following configuration should fix this:
"ember-cli-qunit": "0.3.14"
"ember": "ember#canary",
"ember-data": "ember-data#canary" |
Ok, closing for now. |
A TypeError is triggered when attempting to use a tagless component, although it only seems to occur when the component has no JS file. Creating a JS file for the component makes the issue disappear.
The issue seems to have been introduced in this PR: #12503
Error:
Uncaught TypeError: Cannot read property 'lookup' of undefined
Twiddle showing error (No JS file):
https://ember-twiddle.com/aeb614b5b753fd9f562c
Twiddle with no error (Includes JS file):
https://ember-twiddle.com/33793eecdd0026d524a1
The text was updated successfully, but these errors were encountered: