Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Octane blueprint tests #17737

Closed
ppcano opened this issue Mar 14, 2019 · 2 comments · Fixed by #17740
Closed

Refactor Octane blueprint tests #17737

ppcano opened this issue Mar 14, 2019 · 2 comments · Fixed by #17740
Labels
Octane

Comments

@ppcano
Copy link
Contributor

ppcano commented Mar 14, 2019

The Octane edition does not finally enable the MU layout. The blueprint looks to work well on Octane apps, but the blueprint tests for Octane set incorrectly the EMBER_CLI_MODULE_UNIFICATION variable.

We have to change the behavior of enableOctane function and fix the blueprint test assertions.
@rwjblue rwjblue added the Octane label Mar 14, 2019
@ppcano
Copy link
Contributor Author

ppcano commented Mar 14, 2019

Working on it.

@ppcano ppcano mentioned this issue Mar 14, 2019
Merged
@ppcano
Copy link
Contributor Author

ppcano commented Mar 14, 2019

Closed by #17740

@ppcano ppcano closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Octane
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix octane component blueprint and octane blueprint tests ppcano/ember.js
2 participants
@rwjblue @ppcano