Cannot find module '@babel/plugin-proposal-object-rest-spread'

[simonihmig]

Seen this in one of my addons, but also happening here in CI.

This is happening because of some sloppy dependency handling in plugin-rollup-ts, as it tries to resolve these babel blugins without actually declaring any dependency whatsoever on them. I guess this accidentally worked because of some looseness of package managers, where some other dependency brought those in. Strangely enough that was even the case for pnpm!

This was only popping up now (when ignoring the lockfile!), presumably because those other dependencies changed something to not make those plugins resolvable anymore..

As already reported in wessberg/rollup-plugin-ts#189 long time ago, using these plugins shouldn't actually happen at all. So I hope landing this PR will actually fix both issues.

Also reported upstream here, posting here for visibility.

[ijlee2]

I've seen the error happen since about a month ago, after updating an unrelated package (e.g. eslint plugin). As a temporary fix, I patched rollup-plugin-ts by removing code.

https://github.com/ijlee2/ember-container-query/blob/4.0.4/patches/rollup-plugin-ts%403.2.0.patch (pnpm only)

[simonihmig]

Likely the solution will be to drop rollup-plugin-ts, see #136

[NullVoxPopuli]

Looks resolved! We can re-open if this is still an issue with the latest blueprint