-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the _babel_filter_ file and skipBabel option from Embroider options #1963
Comments
BlueCutOfficial
changed the title
remove the babel filter file and remove the skipBabel option from embroider options
Remove the _babel_filter_ file and skipBabel option from Embroider options
Jul 5, 2024
This is blocked on #2016 |
Fixed by #2102 |
github-project-automation
bot
moved this from Waiting
to Done
in Embroider Working Group
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
skipBabel
is a build option. But in the new way of writing Ember apps, we don't want the build options to control Babel, we prefer the config filebabel.config.cjs
to be the source of truth. This PR removesskipBabel
as a build option and removes the_babel_filter_.js
whose content depends on that option.Issue number #1962 introduces a more standard shape for
babel.config.cjs
. One piece of this issue is to rely on real babel config options to skip files to achieve what the build optionskipBabel
used to do. e.g. we could use the https://babeljs.io/docs/options#exclude option 👍 so we don't need to provide a custom escape hatch any more.That's why the PR for the present issue should be merged only after #1962 is implemented and merged:
babel.config.cjs
to skip files (implement the "correct solution" for babel config in vite #1962)skipBabel
option from Embroider (the present issue)The text was updated successfully, but these errors were encountered: