Schema Slowdown Fix #218
Merged
Schema Slowdown Fix #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -110,4 +110,8 @@ const ( | |||
|
|
|||
| // ConfigDeviceScanType is a config key. | |||
| ConfigDeviceScanType = ConfigRoot + ".device.scanType" | |||
|
|
|||
| // ConfigSchemaResponseValidation is a config key. | |||
There was a problem hiding this comment.
comment on exported const ConfigSchemaResponseValidationEnabled should be of the form "ConfigSchemaResponseValidationEnabled ..."
This patch makes schema response validation an optional step that is disabled by default. The key `libstorage.schema.responseSchemaValidationEnabled` can be set to `true` to enable validation of a response's content against its defined schema.
akutz
force-pushed
the
bugfix/schema-slowdowns
branch
from
2fc4f01 to
fc40ea0
Compare
Current coverage is 32.37%@@ master #218 diff @@
==========================================
Files 36 36
Lines 1909 1909
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 619 618 -1
- Misses 1223 1224 +1
Partials 67 67
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes schema response validation an optional step that is disabled by default. The key
libstorage.schema.responseValidationEnabledcan be set totrueto enable validation of a response's content against its defined schema.