From 1ba8b3c82798133340de1e15a31cba4d3f8f6ea5 Mon Sep 17 00:00:00 2001 From: Emily Date: Tue, 19 Nov 2024 21:23:42 +0000 Subject: [PATCH] qmk: use the default GCC version for AVR MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Upstream previously recommended GCC 8 when targeting AVR because of binary size concerns. They have since removed this warning in , as more recent GCC versions have resolved the issues. Building `keyboardio/model01` before: * The firmware size is fine - 26984/28672 (94%, 1688 bytes free) And after: * The firmware size is fine - 27200/28672 (94%, 1472 bytes free) +216 bytes (1.008× the total size) is not a big deal. Since upstream is fine with it these days, we can be too, and not keep around an unsupported compiler just for QMK. --- pkgs/by-name/qm/qmk/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/qm/qmk/package.nix b/pkgs/by-name/qm/qmk/package.nix index c550d765388725..b45d480ba16d15 100644 --- a/pkgs/by-name/qm/qmk/package.nix +++ b/pkgs/by-name/qm/qmk/package.nix @@ -45,7 +45,7 @@ python3.pkgs.buildPythonApplication rec { gnumake pkgsCross.avr.buildPackages.binutils pkgsCross.avr.buildPackages.binutils.bintools - pkgsCross.avr.buildPackages.gcc8 + pkgsCross.avr.buildPackages.gcc pkgsCross.avr.libcCross ];