Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

licence does not work with metadata #157

Closed
francescalb opened this issue Apr 29, 2021 · 5 comments
Closed

licence does not work with metadata #157

francescalb opened this issue Apr 29, 2021 · 5 comments

Comments

@francescalb
Copy link
Collaborator

onto.metadata.licence(append('LGPL/CC'))

Traceback (most recent call last):
File "periodic-table.py", line 115, in
onto.metadata.licence.append(en(
File "/home/francescab/python-environments-linux/emmopy/lib/python3.8/site-packages/owlready2/namespace.py", line 1239, in getattr
values = [self.namespace.ontology._to_python(o, d) for o, d in self.namespace.world._get_triples_sp_od(self.storid, Prop.storid)]
AttributeError: 'NoneType' object has no attribute 'storid'

Test the commented out line in examples/periodic-table.py in branch peridic-table-example

@francescalb
Copy link
Collaborator Author

This is because license is defined, and not licence. Should be possible to use both american and british spelling I think

@jesper-friis
Copy link
Collaborator

The spelling depends on the ontology. I guess that you are using Dublin Core terms (http://purl.org/dc/terms/) which uses english spelling.

@francescalb
Copy link
Collaborator Author

No, I was using an EMMObased-ontology, so it is defined from there. My suggestions was only to have a check for if we licence is written in metadata it will be changed to license if that is defined. And if tou search for licence in metadata it will give the license if that is defined and not licence. But it is a picky thing, maybe not so important?

@jesper-friis
Copy link
Collaborator

I see. I think that we should leave it to the ontology to add language support, rather than doing it in EMMO-python. What happens if you add the American spelling to the license annotation attribute?

@francescalb
Copy link
Collaborator Author

Ok, then I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants