Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native #119

Closed
steida opened this issue Jul 10, 2017 · 22 comments
Closed

React Native #119

steida opened this issue Jul 10, 2017 · 22 comments

Comments

@steida
Copy link

steida commented Jul 10, 2017

Is React Native version planned?

@tkh44
Copy link
Member

tkh44 commented Jul 11, 2017

Not currently.

@tkh44 tkh44 closed this as completed Jul 11, 2017
@loganpowell
Copy link

Looks like emotion is a real contender for unseating styled-components and a native effort might be the nail in the coffin. Just sayin'

@lukewlms
Copy link

@loganpowell glamorous has native support, I'm really pleased with our results from that lib.

@loganpowell
Copy link

@lukewlms yes, but the preference is for the template string ('just css') paradygm on our end...

@collegeimprovements
Copy link

Maybe now !!!! As styled-component and glamor provide it out of the box now. But we love emotion.

@eugenehp
Copy link

+1

@brunolemos
Copy link

Why is this closed btw? Isn't there any interest in this, even by a community effort?

@tkh44 tkh44 reopened this Mar 29, 2018
@tkh44
Copy link
Member

tkh44 commented Mar 29, 2018

Please put the word out that we want this.

@ilyanoskov
Copy link

yes, that will be great! looking forward to have this

@ludvigalden
Copy link

Yes! I'm loving emotion and right now it seems like I'll have to use styled-components for React Native with a similar syntax. Erase that reason to switch guys!!!11

@jonsherrard
Copy link

If anyone has any inkling on how this might be implemented, I could take a look.

I guess I could look at Styled Components...

Update: I have looked:

This is the PR from Styled Components that got it working on Native Initially: https://github.com/styled-components/styled-components/pull/53/files

I'll have a play around this week.

@DavideDaniel
Copy link

DavideDaniel commented May 4, 2018

This is actually one of the make or break use cases in some decisions around alignment on which solution is ideal. But it'll have to come from community I'm guessing...

@SimeonC SimeonC mentioned this issue May 16, 2018
9 tasks
@Jaikant
Copy link

Jaikant commented Jun 3, 2018

oh. I have been using emotion with react. Just stepped into react-native and I was so hoping emotion is supported.

@t49tran
Copy link

t49tran commented Jun 13, 2018

👍 +1

@zsajjad
Copy link

zsajjad commented Jun 20, 2018

@DavideDaniel any update on this?

@brunolemos
Copy link

Seems like #658 is ready to be merged

@brunolemos
Copy link

#658 got merged! Maybe this can be closed now? cc @steida

@Andarist
Copy link
Member

Andarist commented Jul 6, 2018

While #658 should work in RN this is a specific use case (primitives). General RN integration could still be developed.

@steida steida closed this as completed Jul 6, 2018
@brunolemos
Copy link

brunolemos commented Jul 6, 2018

Just tested!

import React, { PureComponent } from 'react'

import styled from '@emotion/primitives'

const Container = styled.View`
  flex: 1;
  justify-content: center;
  align-items: center;
  background-color: #f5fcff;
`

const Title = styled.Text`
  font-size: 20px;
  text-align: center;
  color: hotpink;
`

const Description = styled.Text`
  text-align: center;
  color: #333333;
  margin-bottom: 5px;
`
export default class App extends PureComponent {
  render() {
    return (
      <Container>
        <Title>Welcome to Emotion Primitives</Title>
        <Description>Style and render primitives across targets.</Description>
      </Container>
    )
  }
}

@Enalmada
Copy link

Enalmada commented Aug 8, 2018

Can someone explain/estimate the amount of community effort that remains to be able to consider emotion-js having enough react native support that it could be considered a viable alternative to styled-components, fela, or glamorous-native? The above post makes it feel so close to the finish line that alternatives have already crossed and I would love to see emotion-js keep the momentum going so that what might be the biggest reason most people can't migrate from styled-components/fela goes away.

@Andarist
Copy link
Member

Andarist commented Aug 8, 2018

Most work was done by @nitin42 , so I think he should answer on that question :)

@jfrolich
Copy link

Awesome work folks! Especially @nitin42, will use this in the native app I'm working on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests