Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file should be included in npm bundle #1694

Closed
nappy opened this issue Dec 17, 2019 · 3 comments · Fixed by #1698
Closed

LICENSE file should be included in npm bundle #1694

nappy opened this issue Dec 17, 2019 · 3 comments · Fixed by #1698

Comments

@nappy
Copy link

nappy commented Dec 17, 2019

The license text is currently not provided with the npm bundle.
In order to allow automation tools like license-webpack-plugin to pick it up, it should be included there.
Also the license states: The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
This includes the npm registry.

@Andarist
Copy link
Member

Do you require license text everywhere? Why license field is not enough? It points to MIT license which has known content that can be checked in a lot of places on the internet - for example here: https://opensource.org/licenses/MIT

@nappy
Copy link
Author

nappy commented Dec 21, 2019

a) Not I require it, the license requires it.
b) Its not required everywhere but In all copies or substantial portions of the software, which an npm package definitely is.
c) The generic text does not include year and copyright holder and might change over time. Also there is no link to the URL where it could be sourced from automatically.
d) 90% of the packages I (indirectly) depend on already do it this way, so its the best practice.
e) If yourself do not include the license text, how much sense make it to you to require it from your dependents which bundle/distribute that code?

@Andarist
Copy link
Member

Ok, I've created a PR to add this - #1698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants