Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toHaveStyleRule to jest-emotion #645

Closed
fernandofleury opened this issue May 7, 2018 · 7 comments
Closed

Add toHaveStyleRule to jest-emotion #645

fernandofleury opened this issue May 7, 2018 · 7 comments

Comments

@fernandofleury
Copy link

First of all thanks for the library! I've using and enjoying it a lot lately.

I was wondering if there are any plans to add something like toHaveStyleRule to jest-emotion, something similar to what jest-styled-components have: https://github.com/styled-components/jest-styled-components#usage

I'd like to be able to test the output of style generation instead of just matching it against a snapshot.

Thanks!

@emmatown
Copy link
Member

emmatown commented May 8, 2018

We're not planning on adding it but we'd happily accept a PR adding it!!

@fernandofleury
Copy link
Author

Cool! I'll see how I can help with this then 😄

@danreeves
Copy link
Contributor

@fernandofleury I worked on adding this feature to jest-glamor-react, which jest-emotion is based on. This file should be helpful: https://github.com/kentcdodds/jest-glamor-react/blob/master/src/matchers.js

If you don't get around to it I'd be happy to pick this up

@fernandofleury
Copy link
Author

Thanks @danreeves! I'm hoping to pick this during the weekend.

@fernandofleury
Copy link
Author

hey @danreeves would you mind picking this one up? 👀

@danreeves
Copy link
Contributor

Sure thing! I'll try and work it in this week

@Ailrun
Copy link
Member

Ailrun commented Jun 8, 2018

I believe this is resolved in #662.
Thank you for reporting an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants