From 380a9dda76a35fdd4f4cd94c606d6d375862392a Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Fri, 2 Feb 2024 15:36:18 +0000 Subject: [PATCH] Fix test_cubegeom_pre_relocatable (#21240) This test was broken by #21103 but when unnoticed because we run our browser tests with swiftshader enabled, which skips this test. --- test/test_browser.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/test_browser.py b/test/test_browser.py index 8addd173f2553..d3318222d1cb8 100644 --- a/test/test_browser.py +++ b/test/test_browser.py @@ -2085,7 +2085,10 @@ def test_cubegeom_pre_regal(self): @requires_graphics_hardware @no_swiftshader def test_cubegeom_pre_relocatable(self): - self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL', '-sRELOCATABLE']) + # RELOCATABLE needs to be set via `set_setting` so that it will also apply when + # building `browser_reporting.c` + self.set_setting('RELOCATABLE') + self.btest('third_party/cubegeom/cubegeom_pre.c', reference='third_party/cubegeom/cubegeom_pre.png', args=['-sLEGACY_GL_EMULATION', '-lGL', '-lSDL']) @requires_graphics_hardware @no_swiftshader