Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Move linked issues adjacent to their linked PRs #14

Closed

Conversation

mbestavros
Copy link
Contributor

Adds an action to move issues next to their linked PRs on the sprint board.

Resolves #13.

@mbestavros mbestavros requested a review from npmccallum July 17, 2020 15:05
@mbestavros mbestavros force-pushed the linked-issue-actions-2 branch from 98414a1 to db6bf8a Compare July 17, 2020 15:06
@mbestavros mbestavros force-pushed the linked-issue-actions-2 branch from db6bf8a to 47b3263 Compare July 17, 2020 16:43
@mbestavros mbestavros force-pushed the linked-issue-actions-2 branch 3 times, most recently from 0d5550e to ca7e2ce Compare July 17, 2020 20:14
Copy link
Contributor

@npmccallum npmccallum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm rethinking the value of this PR now since GH doesn't merge the issue and PR. In the Sprint board, we basically have three columns: the one that contains issues, the one that contains PRs and done. Thoughts?

# Extract all associated issues from PR commit messages
for c in pr.get_commits():
for verb, num in regex.findall(c.commit.message):
yield int(num)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to share this function? We use it multiple places. It would probably be useful.

content = card.get_content()
if content:
card_cache[content.id] = (card, column)
return card_cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share this code?

@mbestavros
Copy link
Contributor Author

My latest push adds a shared common.py with functions used across actions. Also replicated in #10.

@mbestavros mbestavros requested a review from npmccallum July 21, 2020 18:44
@mbestavros mbestavros force-pushed the linked-issue-actions-2 branch from 619ab52 to d3caef1 Compare July 21, 2020 18:56
@mbestavros
Copy link
Contributor Author

My latest push fixes a duplicate bug with get_related_issues.

@mbestavros mbestavros force-pushed the linked-issue-actions-2 branch 5 times, most recently from 0af3222 to a213f8e Compare July 23, 2020 19:48
@mbestavros mbestavros marked this pull request as draft August 10, 2020 18:46
@mbestavros
Copy link
Contributor Author

We've since moved on from REST API v3, so this will need to be rewritten. Closing in favor of a new PR eventually.

@mbestavros mbestavros closed this Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprint automation: when a PR links to an issue, move the issue across the sprint board with the PR
9 participants