Skip to content
This repository has been archived by the owner on Jun 30, 2020. It is now read-only.

Implement an automated test to detect merge commits #24

Open
mbestavros opened this issue Nov 6, 2019 · 2 comments
Open

Implement an automated test to detect merge commits #24

mbestavros opened this issue Nov 6, 2019 · 2 comments
Assignees

Comments

@mbestavros
Copy link
Contributor

Enarx projects should not contain merge commits, and we'd like to test incoming pull requests to ensure they do not contain any.

The best way to go about this is probably to detect whether individual commits have multiple parents. There is no simple one-line way to do this, so we'll need to implement it from scratch (probably by iterating through PR commits and analyzing them).

@mbestavros mbestavros self-assigned this Nov 6, 2019
@frozencemetery
Copy link
Contributor

Is this actually needed? Wouldn't it be caught during normal code review anyway?

@npmccallum
Copy link
Contributor

@frozencemetery Never leave to human error what can be enforced by a heartless computer!

We are enforcing lots of things as tests, including linting, documentation, etc. We want to catch all these things before a human gets involved. Passing tests should be an indication that it is ready for human review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants