-
Notifications
You must be signed in to change notification settings - Fork 8
[WIP]: initial custom WASI demo #23
base: master
Are you sure you want to change the base?
[WIP]: initial custom WASI demo #23
Conversation
d030682
to
73be3ae
Compare
I expect this demo to evolve over time as wasmtime-api evolves as well as our customization of the WASI functionality. we have two options to evolve it: a) always only have the most-recent version in master and add a changelog to its README and b) have one directory per version I'm slightly in favor of (a) based on that we only want to demo the most recent state. @npmccallum @mbestavros what are your thoughts on this? |
cba0a87
to
bf42cab
Compare
It would be neat if we could run the new test suite in PR #22 against this, @npmccallum 😉 |
bf42cab
to
3ad8666
Compare
What's blocking us from doing that? |
3ad8666
to
7764966
Compare
@steveej Just that the linked PR #22 is still open, and not merged yet. I've since addressed your feedback on it, and it's rebased on top of the latest master. I haven't gotten any additional feedback from @npmccallum yet, so I don't know if there's anything else blocking its merge. |
7764966
to
ce1a946
Compare
This demo is the trivial approach to implementing a custom WASI. It contains a copy of the wasmtime-wasi implementation, which is rather a short-term solution and not sustainable any longer than a few iterations. As a demo customization, it redirects all output from fd=2 (stderr) to fd=1 (stdout).
ce1a946
to
02ebad0
Compare
This demo is the trivial approach to implementing a custom WASI. It
contains a copy of the wasmtime-wasi implementation, which is rather a
short-term solution and not sustainable any longer than a few
iterations.
As a demo customization, it redirects all output from fd=2 (stderr) to
fd=1 (stdout).
Fixes #10.