Skip to content
This repository has been archived by the owner on Jul 16, 2020. It is now read-only.

[WIP]: initial custom WASI demo #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

steveej
Copy link
Contributor

@steveej steveej commented Sep 19, 2019

This demo is the trivial approach to implementing a custom WASI. It
contains a copy of the wasmtime-wasi implementation, which is rather a
short-term solution and not sustainable any longer than a few
iterations.

As a demo customization, it redirects all output from fd=2 (stderr) to
fd=1 (stdout).

Fixes #10.

@steveej steveej changed the title initial custom WASI demo [WIP]: initial custom WASI demo Sep 19, 2019
@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch from d030682 to 73be3ae Compare September 19, 2019 17:16
@steveej
Copy link
Contributor Author

steveej commented Sep 19, 2019

I expect this demo to evolve over time as wasmtime-api evolves as well as our customization of the WASI functionality. we have two options to evolve it: a) always only have the most-recent version in master and add a changelog to its README and b) have one directory per version I'm slightly in favor of (a) based on that we only want to demo the most recent state.

@npmccallum @mbestavros what are your thoughts on this?

@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch 2 times, most recently from cba0a87 to bf42cab Compare September 19, 2019 17:33
@mbestavros
Copy link
Contributor

It would be neat if we could run the new test suite in PR #22 against this, @npmccallum 😉

@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch from bf42cab to 3ad8666 Compare September 23, 2019 13:25
@steveej
Copy link
Contributor Author

steveej commented Oct 3, 2019

It would be neat if we could run the new test suite in PR #22 against this, @npmccallum wink

What's blocking us from doing that?

@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch from 3ad8666 to 7764966 Compare October 3, 2019 18:22
@mbestavros
Copy link
Contributor

@steveej Just that the linked PR #22 is still open, and not merged yet. I've since addressed your feedback on it, and it's rebased on top of the latest master. I haven't gotten any additional feedback from @npmccallum yet, so I don't know if there's anything else blocking its merge.

@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch from 7764966 to ce1a946 Compare October 4, 2019 12:25
This demo is the trivial approach to implementing a custom WASI. It
contains a copy of the wasmtime-wasi implementation, which is rather a
short-term solution and not sustainable any longer than a few
iterations.

As a demo customization, it redirects all output from fd=2 (stderr) to
fd=1 (stdout).
@steveej steveej force-pushed the pr/wasm-wasi-custom-0.1-copynpaste branch from ce1a946 to 02ebad0 Compare October 10, 2019 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WASM: demo a custom WASI function implementation
2 participants