This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Basic Rust testing + merge commit detection with Github Actions #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbestavros
force-pushed
the
github-actions-test
branch
3 times, most recently
from
78279c2 to
0928a83
Compare
mbestavros
force-pushed
the
github-actions-test
branch
2 times, most recently
from
3177227 to
225fa40
Compare
mbestavros
force-pushed
the
github-actions-test
branch
from
225fa40 to
9a60949
Compare
|
We've learned from this pull request that GH Actions will not actually run new tests added by pull requests from forked repositories, which makes it rather useless for us as a CI solution. I'm closing this PR and will be porting over the new test into Travis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Github Actions' general availability date fast approaching (Nov. 13th at time of writing), we figured it'd be a good idea to test the waters by implementing a new check we've been thinking about: detecting merge commits on incoming pull requests.
The test itself is a one-liner, and works by iterating through all commits new on a pull request and checking if they have multiple parents (a characteristic of merge commits). If it finds any, it fails; if not, it succeeds.
This test is implemented inside a shiny new Github Actions testing config! I've included a few basic Rust tests (build, test, formatting) and arranged them to demonstrate how tests might be organized with GH Actions. There's some nice integration throughout the Github UI; it'll be interesting to see how well it fares once it hits GA.
Resolves #47.