Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeField render returns None instead of 00:00:00 #4105

Closed
5 tasks done
ehumet opened this issue May 8, 2016 · 2 comments
Closed
5 tasks done

TimeField render returns None instead of 00:00:00 #4105

ehumet opened this issue May 8, 2016 · 2 comments
Labels
Milestone

Comments

@ehumet
Copy link

ehumet commented May 8, 2016

Checklist

  • I have verified that that issue exists against the master branch of Django REST framework.
  • I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
  • This is not a usage question. (Those should be directed to the discussion group instead.)
  • This cannot be dealt with as a third party library. (We prefer new functionality to be in the form of third party libraries where possible.)
  • I have reduced the issue to the simplest possible case.
  • [] I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)

Steps to reproduce

  1. Create a model A with a TimeField B in it.
  2. Create an instance C of the model A in which the TimeField B has a "00:00:00" value (midnight).
  3. Create a default DRF serializer D for the model A.
  4. Render the object C through serializer D

Expected behavior

It should render the TimeField B as "00:00:00".

Actual behavior

It actually gets rendered as None.

@tomchristie tomchristie added this to the 3.3.4 Release milestone May 9, 2016
@tomchristie tomchristie added the Bug label May 9, 2016
@tomchristie
Copy link
Member

Confirmed.

@tomchristie
Copy link
Member

Now resolved in master - thanks for raising the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants