You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
user.is_authenticated() is used throughout code (I first noticed it in permissions.py), but in Django 1.10 is_authenticated is now a property, rather than a method.
This causes a warning in Django 1.10, but in Django 2.0 this code will cease to work.
The full exception message is Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
I have reduced the issue to the simplest possible case.
I have included a failing test as a pull request. (If you are unable to do so we can still accept the issue.)
Steps to reproduce
I imagine the easiest way to reproduce this would be to just run DRF's tests and look out for the warnings, or to run tests with -Werror. I reproduced the issue by running a test that calls an API endpoint with APIView as the parent class and with the IsAuthenticated permissions class.
Expected behavior
No warning.
Actual behavior
RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
The text was updated successfully, but these errors were encountered:
user.is_authenticated()
is used throughout code (I first noticed it inpermissions.py
), but in Django 1.10is_authenticated
is now a property, rather than a method.This causes a warning in Django 1.10, but in Django 2.0 this code will cease to work.
The full exception message is
Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
Ref: https://docs.djangoproject.com/en/1.10/releases/1.10/#using-user-is-authenticated-and-user-is-anonymous-as-methods
Checklist
master
branch of Django REST framework.Steps to reproduce
I imagine the easiest way to reproduce this would be to just run DRF's tests and look out for the warnings, or to run tests with
-Werror
. I reproduced the issue by running a test that calls an API endpoint withAPIView
as the parent class and with theIsAuthenticated
permissions class.Expected behavior
No warning.
Actual behavior
RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
The text was updated successfully, but these errors were encountered: