Reload only working when app is supplied as string

[soslan]

Hi! I am tinkering with programmatic start of uvicorn server, and encountered this unexpected behavior. When I supply an ASGIApplication to Config(), reload functionality is not working because should_reload checks whether self.app is a string and returns False:

uvicorn/uvicorn/config.py

Lines 528 to 530 in 90f4369

	@property
	def should_reload(self) -> bool:
	return isinstance(self.app, str) and self.reload

Instead of working reload functionality, I see this:

uvicorn/uvicorn/config.py

Lines 281 to 284 in 90f4369

	if (reload_dirs or reload_includes or reload_excludes) and not self.should_reload:
	logger.warning(
	"Current configuration will not reload as not all conditions are met, " "please refer to documentation."
	)

But there is nothing in the docs that mentions what conditions are required for the reload to work.

Is this a bug or reload only works with str-defined app for a reason? If it is a bug, I am willing to contribute by fixing it.

[Kludex]

If the string is provided, uvicorn will try to import it. If it's the app itself, it will try to use it, but reload runs on another process.

I think... If you can make a way to pass the app location as string to the reloader, then it would work.

But it's expected as of today.