Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] properly serialize balances #145

Closed
clangenb opened this issue Feb 14, 2022 · 0 comments · Fixed by #146
Closed

[rpc] properly serialize balances #145

clangenb opened this issue Feb 14, 2022 · 0 comments · Fixed by #146

Comments

@clangenb
Copy link
Member

We are currently using a hack for how we encointer BalanceEntry:

pallets/balances/rpc/src/lib.rs

Line 82 in b50b6c1

// serde can't cope with i128 and panics. So we need to hand-encode the value here

This hack is obsolete if we use the correct serde attribute like we use here:

pallets/primitives/src/communities.rs

Line 176 in b50b6c1

#[cfg_attr(feature = "serde_derive", serde(with = "serialize_fixed"))]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[balances] fix balance entry serde hack encointer/pallets
1 participant
@clangenb