Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test cover cli demo #2368

Closed
8 of 9 tasks
grypez opened this issue Jul 18, 2024 · 1 comment · Fixed by #2384
Closed
8 of 9 tasks

test cover cli demo #2368

grypez opened this issue Jul 18, 2024 · 1 comment · Fixed by #2384
Assignees
Labels

Comments

@grypez
Copy link
Contributor

grypez commented Jul 18, 2024

What is the Problem Being Solved?

The cli package is not currently tested. It would be nice to write some tests, and the demo seems like a good place to start.

Description of the Design

  • Activate ava test coverage in cli package
  • Create an ava entry point which tests each section in isolation after running endo purge -f.

For each runnable section of the cli demo, produce a bash script executing that functionality and a log of the expected output of the script, then assert equality of the expected and observed output of the script using diff (for an example see the description of this issue).

  • A counter example
  • Doubler Agent
  • Sending Messages
  • Names in transit...
  • Mailboxes are symmetric
  • Familiar Chat (note UI interaction)
  • Running a confined script

Out of Scope

  • Programmatically ensuring that the documented functionality aligns with the tested functionality
@grypez grypez added the test label Jul 18, 2024
@grypez grypez self-assigned this Jul 18, 2024
@kriskowal
Copy link
Member

You may have more luck ensuring portability if the tests are framed as Node.js shelling out to the CLI. Execa is popular at Agoric. https://www.npmjs.com/package/execa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants