Skip to content

Commit

Permalink
improve focus example (#147464)
Browse files Browse the repository at this point in the history
Part of #130459. Adds a test to the [second focus example](https://api.flutter.dev/flutter/widgets/Focus-class.html#widgets.Focus.2) and makes the function of the example more clear.
  • Loading branch information
derdilla authored May 7, 2024
1 parent be3e916 commit a7bdf36
Show file tree
Hide file tree
Showing 3 changed files with 101 additions and 2 deletions.
1 change: 0 additions & 1 deletion dev/bots/check_code_samples.dart
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ final Set<String> _knownMissingTests = <String>{
'examples/api/test/widgets/actions/focusable_action_detector.0_test.dart',
'examples/api/test/widgets/color_filter/color_filtered.0_test.dart',
'examples/api/test/widgets/focus_scope/focus.2_test.dart',
'examples/api/test/widgets/focus_scope/focus.1_test.dart',
'examples/api/test/widgets/focus_scope/focus_scope.0_test.dart',
'examples/api/test/widgets/scroll_view/custom_scroll_view.1_test.dart',
'examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart',
Expand Down
2 changes: 1 addition & 1 deletion examples/api/lib/widgets/focus_scope/focus.1.dart
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class FocusableText extends StatelessWidget {
return Container(
padding: const EdgeInsets.all(8.0),
// Change the color based on whether or not this Container has focus.
color: Focus.of(context).hasPrimaryFocus ? Colors.black12 : null,
color: Focus.of(context).hasPrimaryFocus ? Colors.red : Colors.white,
child: Text(data),
);
}),
Expand Down
100 changes: 100 additions & 0 deletions examples/api/test/widgets/focus_scope/focus.1_test.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_api_samples/widgets/focus_scope/focus.1.dart'
as example;
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('FocusableText shows content and color depending on focus',
(WidgetTester tester) async {
await tester.pumpWidget(const MaterialApp(
home: Scaffold(
body: example.FocusableText(
'Item 0',
autofocus: false,
),
),
));
// Autofocus needs to check that no other node in the [FocusScope] is
// focused and can only request focus for the second frame.
await tester.pumpAndSettle();
expect(find.descendant(
of: find.byType(example.FocusableText),
matching: find.byType(Focus),
), findsOneWidget);
expect(find.text('Item 0'), findsOneWidget);

expect(find.byType(Container), findsOneWidget);
final Container container1 = tester.widget<Container>(
find.byType(Container)
);
expect(container1.color, Colors.white);

await tester.pumpWidget(const MaterialApp(
home: Scaffold(
body: example.FocusableText(
'Item 1',
autofocus: true,
),
),
));
await tester.pumpAndSettle();

final Finder focusableTextFinder2 = find.ancestor(
of: find.text('Item 1'),
matching: find.byType(example.FocusableText),
);
expect(tester.widget<Focus>(find.descendant(
of: focusableTextFinder2,
matching: find.byType(Focus),
)).autofocus, isTrue);
final Container container2 = tester.widget<Container>(find.descendant(
of: focusableTextFinder2,
matching: find.byType(Container),
));
expect(container2.color, Colors.red);
});

testWidgets('builds list showcasing focus traversal',
(WidgetTester tester) async {
await tester.pumpWidget(const example.FocusExampleApp());
await tester.pumpAndSettle();

expect(find.byType(ListView), findsOneWidget);

final Finder childFinder = find.descendant(
of: find.byType(ListView),
matching: find.byType(example.FocusableText),
);
expect(childFinder, findsAtLeastNWidgets(2));

Container container0 = tester.widget<Container>(find.descendant(
of: childFinder.first,
matching: find.byType(Container),
));
Container container1 = tester.widget<Container>(find.descendant(
of: childFinder.at(1),
matching: find.byType(Container),
));
expect(container0.color, Colors.red);
expect(container1.color, Colors.white);

await tester.sendKeyDownEvent(LogicalKeyboardKey.arrowDown);
await tester.pumpAndSettle();

container0 = tester.widget<Container>(find.descendant(
of: childFinder.first,
matching: find.byType(Container),
));
container1 = tester.widget<Container>(find.descendant(
of: childFinder.at(1),
matching: find.byType(Container),
));
expect(container0.color, Colors.white);
expect(container1.color, Colors.red);
});
}

0 comments on commit a7bdf36

Please sign in to comment.