fix incorrect Bad Gateway error code

[thumbsupep]

graphql-ws/src/client.ts

Lines 1082 to 1097 in 4f4ac19

	function isFatalInternalCloseCode(code: number): boolean {
	if (
	[
	1000, // Normal Closure is not an erroneous close code
	1001, // Going Away
	1006, // Abnormal Closure
	1005, // No Status Received
	1012, // Service Restart
	1013, // Try Again Later
	1013, // Bad Gateway
	].includes(code)
	)
	return false;
	// all other internal errors are fatal
	return code >= 1000 && code <= 1999;
	}

Expected Behaviour
1014 is used for Bad Gateway so that Bad Gateway is not treated as a fatal error.

Actual Behaviour
1013 is considered both Try Again Later and Bad Gateway so Bad Gateway errors are incorrectly classified as fatal.

Further Information
Websocket connection close code for Bad Gateway should be 1014 https://developer.mozilla.org/en-US/docs/Web/API/CloseEvent/code#value

This will be a breaking change because there might be consumers who need to update error handling to prevent a change in behavior for the 1014 close code.

I would love to contribute this change, but could only find documentation on opening an issue, not creating a PR.

[enisdenjo]

Great find! PR is more than welcome. However, I don't think this will be a breaking change.

[enisdenjo]

Closed with #512.

[enisdenjo]

🎉 This PR is included in version 5.14.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀