Socket is closed even though there are pending subscriptions

[rpastro]

I'm using graphql-ws together with Apollo client.

I noticed that for queries and mutations the cancellerRef.current is being invoked twice. Once when the Complete message is received and again from the cleanup function.

As a result state.locks gets decremented twice for the same operation, which causes the socket to be closed even though there are pending operations.

[enisdenjo]

Hmm, are you sure? I reckon this test would be failing then because of the double decrement:

graphql-ws/src/tests/client.ts

Lines 500 to 537 in 3f4f836

	it('should disconnect on last unsubscribe when mode is enabled', async () => {
	const { url, ...server } = await startTServer();
	const client = createClient({
	url,
	lazy: true, // default
	retryAttempts: 0,
	});
	await server.waitForClient(() => {
	fail('Client shouldnt have appeared');
	}, 10);
	const sub1 = tsubscribe(client, {
	operationName: 'PingPlease',
	query: 'subscription PingPlease { ping }',
	});
	await server.waitForOperation();
	const sub2 = tsubscribe(client, {
	operationName: 'Pong',
	query: 'subscription Pong($key: String!) { ping(key: $key) }',
	variables: { key: '1' },
	});
	await server.waitForOperation();
	sub1.dispose();
	await sub1.waitForComplete();
	// still is connected
	await server.waitForClientClose(() => {
	fail('Client should have closed');
	}, 10);
	// everyone unsubscribed
	sub2.dispose();
	await server.waitForClientClose();
	});

Maybe the test is flawed? 🤔

[rpastro]

The problems happens with queries and mutations where the server sends the Completed event. What I noticed, at least with Apollo, is that the cleanup function gets invoked almost at the same time which causes the cancellerRef.current to be called twice for the same subscription.

[rpastro]

BTW, this is the cleanup function I'm referring to.

      return () => {
        cancellerRef.current?.();
      };

[enisdenjo]

Ah, I follow. I was thinking about the canceller cleanup, the one in it haha.

Nevertheless, you're right, it can sure happen. I'll head over to your PR. 😄

[enisdenjo]

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀