Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra checks #1

Open
makoto opened this issue Mar 8, 2021 · 0 comments
Open

Add extra checks #1

makoto opened this issue Mar 8, 2021 · 0 comments

Comments

@makoto
Copy link
Member

makoto commented Mar 8, 2021

  1. Handle the case if no names are set at https://github.com/ensdomains/reverse-records/blob/master/contracts/ReverseRecords.sol#L30
  2. After the result is returned, [normalise](normalized = namehash.normalize(input)) and compare the value. If the value is different, treat as no resolution
  3. Explain Calling getNames() from another contract reverts. #2 in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant