Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Grunt tool building task work for Windows too #95

Closed
meldckn opened this issue Nov 27, 2019 · 2 comments
Closed

Make Grunt tool building task work for Windows too #95

meldckn opened this issue Nov 27, 2019 · 2 comments

Comments

@meldckn
Copy link
Collaborator

meldckn commented Nov 27, 2019

When you add win64 to the nwjs platforms option of the Gruntfile, it will silently fail without errors when building, and produce a blank nwjs exe.

It would be very helpful if we didn't have two separate, unrelated processes for building Mac and Windows apps. It would mean you don't have to do two different kinds of updating when you want to update nwjs to support modern JavaScript, for example.

The only related issue I could find: This might be because Windows does not allow path names over 256 characters, and we probably have well-nested node_modules directories (somewhere among our 340 installed npm modules!). See discussions on nwutils/nw-builder#107 and nwjs/grunt-nw-builder#118. But I don't think our node modules get packaged with the app? Oh wait I think nwjs automatically looks for a node_modules directory and packages it?

@meldckn
Copy link
Collaborator Author

meldckn commented Nov 27, 2019

Or maybe it'd be better to adopt a different, modern nwjs app build process, since grunt-nw-builder doesn't seem to be super actively maintained anymore?

@mkremins
Copy link
Collaborator

mkremins commented Dec 1, 2019

One neat side effect of the NW.js => Electron upgrade from release v1.1.0: the build processes for the Windows and Mac (and Linux) versions of the authoring tool are now one and the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants