-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial appveyor file #121
Conversation
Hmm, this should be starting a build now... |
I'm looking into it. |
It looks like notifications are configured in the appveyor.yaml file. https://www.appveyor.com/docs/notifications/#github-pull-request |
No, I'm misunderstanding something. That build is for master and notifications only need to be configured for custom templates. Still looking... |
I think that is only for the comment, for example in this appveyor.yml file there are no notifications, but merge requests still get the notification like so: ember-cli/ember-cli#6708 |
I've enabled the webhook. I don't see a way to trigger a branch build from the appveyor interface. Please push another commit. |
That's the ticket! Awesome, I'll have a fiddle tomorrow and see if we can get at least the installation rather than the building passing. |
Cool. Thanks for taking the initiative on this! |
No problem! It seems comtypes uses a VS 2010 build, but the minimum VS that appveyor offers is 2013. Is there any technical reason the project couldn't be updated to 2013? |
No part of the comtypes library actually needs VS. It's there to build a COM server that is used to test that functionality. |
Hmm, my test was simply running |
Oh, my bad, it appears that AppVeyor triggers the build automatically. |
Hey @cfarrow - this MR is ready for merging if you're happy (you might want to let github squash it when you do). I tried to get the tests to run as well but failed. I think they are somewhat broken and need a lot of work to get them running, but for now just running So as I see it the tests appear to run on Python 2.7 32bit only only. 2.6 runs, but fails due to a missing testcase method (https://ci.appveyor.com/project/cfarrow/comtypes/build/1.0.9/job/6uxqxeleqe7j0hgi). All 3.x cases fail with an It seems the tests in general are in a poor state, with a custom test loader that seems pretty old. I'd quite like to convert them to |
We can merge this as-is. I may record the test failures as their own issues, depending on how long they persist. I've moved the pytest discussion to #123. |
Thanks for setting this up! |
Refs #120