Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed extra space in typeinfo.IRecordInfo._methods_ #383

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Removed extra space in typeinfo.IRecordInfo._methods_ #383

merged 1 commit into from
Nov 26, 2022

Conversation

j0ker70
Copy link
Contributor

@j0ker70 j0ker70 commented Nov 25, 2022

[Issue] #381
[Problem] There is a strange, perhaps unnecessary space in typeinfo.IRecordInfo.methods
[Solution] Removed the extra space

[Issue] #381
[Problem] There is a strange, perhaps unnecessary space in typeinfo.IRecordInfo._methods_
[Solution] Removed the extra space
junkmd added a commit to junkmd/pywinauto that referenced this pull request Nov 25, 2022
Copy link
Collaborator

@junkmd junkmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junkmd junkmd merged commit 853f4ad into enthought:master Nov 26, 2022
@junkmd
Copy link
Collaborator

junkmd commented Nov 26, 2022

The CI was successful when this was PRed.
https://ci.appveyor.com/project/cfarrow/comtypes/builds/45493817

However, the CI was failure when this was "squash & merge"d.
https://ci.appveyor.com/project/cfarrow/comtypes/builds/45496442

I think it is due to the CI environment, but I may revert if it still occurs after #384 is merged.

@junkmd
Copy link
Collaborator

junkmd commented Nov 26, 2022

I think it is due to the CI environment, but I may revert if it still occurs after #384 is merged.

The CI result seems ok, so I would not revert this one.
https://ci.appveyor.com/project/cfarrow/comtypes/builds/45496506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a strange, perhaps unnecessary space in typeinfo.IRecordInfo._methods_
2 participants