Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipykernel Heartbeat patch when updating to ipykernel version >5 #298

Closed
rahulporuri opened this issue Aug 14, 2020 · 2 comments
Closed

Comments

@rahulporuri
Copy link
Contributor

rahulporuri commented Aug 14, 2020

The ipykernel Heartbeat was been patched earlier and the patch isn't needed when we update to a new version of ipykernel > 5.x.

The patched Heartbeat is used by the IPKernelApp, which can also be removed

# Methods overridden from the base class ##################################
def init_heartbeat(self):
"""start the heart beating
Overridden from the base class in order to swap in our own
Heartbeat class in place of the official one. Our Heartbeat class
is modified to allow the heartbeat thread to be shut down cleanly.
This override can be removed once we're on ipkernel 5.x.
"""
# heartbeat doesn't share context, because it mustn't be blocked
# by the GIL, which is accessed by libzmq when freeing zero-copy
# messages
hb_ctx = zmq.Context()
self.heartbeat = Heartbeat(
hb_ctx, (self.transport, self.ip, self.hb_port),
)
self.hb_port = self.heartbeat.port
self.log.debug("Heartbeat REP Channel on port: %i" % self.hb_port)
self.heartbeat.start()

https://github.com/enthought/envisage/blob/master/envisage/plugins/ipython_kernel/heartbeat.py

@rahulporuri
Copy link
Contributor Author

FTR

@mdickinson
Copy link
Member

Closing: IPython components have been removed from Envisage.

@mdickinson mdickinson closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants