Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing training environment #4

Open
cswinter opened this issue Jul 24, 2022 · 0 comments
Open

Closing training environment #4

cswinter opened this issue Jul 24, 2022 · 0 comments

Comments

@cswinter
Copy link
Contributor

When creating an environment from Python, there needs to be some way to shut down the threads running the apps. Currently, this is done by having the TrainAgent::act method return an Option<Action> rather than an Action directly. When the counterparts to the channels owned by the TrainAgent are dropped, TrainAgent will return a None value which can be handled by sending an AppExit event. Ideally, Agent::act could just return an action directory and app shutdown would be handled automatically without writing additional code. I don't currently know enough about Bevy to know how to make this work. Maybe there could be an entity-gym Bevy plugin that connects to the train agent and handles app shutdown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant