Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectorEventLoop is never released #59

Closed
v-lavrentikov opened this issue Aug 7, 2018 · 1 comment
Closed

SelectorEventLoop is never released #59

v-lavrentikov opened this issue Aug 7, 2018 · 1 comment

Comments

@v-lavrentikov
Copy link

In the SelectorEventLoop initializer you call setReader() method with a callback handler. This callback handler retains self object reference. Thus deinit() method will never be called after releasing SelectorEventLoop reference.
To release object it is needed to call removeReader() method first. It is public, but it parameter pipeReceiver is a private field. It looks like something went wrong.

@fangpenlin
Copy link
Contributor

Hey @v-lavrentikov, thanks for reporting! That's a good caught. Yep, indeed it's creating a reference cycle there, I've already created a PR here #60, will soon merge it and make a new release once the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants