Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using ENVOY_LOG in a custom filter does not compile unless the filter is in the Envoy namespace #12728

Closed
roelfdutoit opened this issue Aug 19, 2020 · 1 comment
Closed

Using ENVOY_LOG in a custom filter does not compile unless the filter is in the Envoy namespace #12728

roelfdutoit opened this issue Aug 19, 2020 · 1 comment

Comments

@roelfdutoit
Copy link
Contributor

Proprietary/custom filters that are not in namespace Envoy will get the following compile error when using ENVOY_LOG():
error: use of undeclared identifier 'getFancyContext'; did you mean 'Envoy::getFancyContext'?

The ENVOY_LOG() macro switched to using FANCY_LOG() as part of #12369
@roelfdutoit roelfdutoit mentioned this issue Aug 19, 2020
Closed
@roelfdutoit
Copy link
Contributor Author

This is a duplicate of #12707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logger: Allow use of ENVOY_LOG/FANCY_LOG outside the Envoy namespace
1 participant
@roelfdutoit