Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: original_dst filter should update downstream local address #13554

Closed
kyessenov opened this issue Oct 14, 2020 · 3 comments · Fixed by #13581
Closed

bug: original_dst filter should update downstream local address #13554

kyessenov opened this issue Oct 14, 2020 · 3 comments · Fixed by #13581
Assignees
@kyessenov
Labels
bug

Comments

@kyessenov
Copy link
Contributor

Prior to #12935, the socket address was already updated before constructing stream info. Now that stream info is created ahead of listener filters, the value for the downstream socket address changed.
@kyessenov kyessenov added bug triage Issue requires triage labels Oct 14, 2020
@kyessenov kyessenov mentioned this issue Oct 14, 2020
Merged
@htuch htuch removed the triage Issue requires triage label Oct 15, 2020
@antoniovicente
Copy link
Contributor

Does this bug affect routing or is it a logging-only issue?

@kyessenov
Copy link
Contributor Author

It affects logging mostly, but may also affect RBAC policies if they reference destination address. I think istio is the most affected downstream project as a heavy user of original_dst.

@mattklein123
Copy link
Member

FWIW I would really love to have an integration test here, I just don't know if it's technically possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyessenov kyessenov

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: record recovered local address kyessenov/envoy
4 participants
@mattklein123 @kyessenov @htuch @antoniovicente