Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uhv: implement default protocol header validations #19753

Closed
Tracked by #20261
ameily opened this issue Jan 31, 2022 · 1 comment · Fixed by #22537
Closed
Tracked by #20261

uhv: implement default protocol header validations #19753

ameily opened this issue Jan 31, 2022 · 1 comment · Fixed by #22537
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue

Comments

@ameily
Copy link
Contributor

ameily commented Jan 31, 2022

As part of the unified header validation component, Envoy will maintain a header validation implementation for each supported codec (h1, h2, h3/quic). This issue will develop concrete implementations for the UHV API (#19752) that include all current header validations. Header validation is currently performed in multiple locations within Envoy and within the underlying parsing libraries. So, part of this issue will be taking an inventory of what validations are performed where and then consolidating them into the UHV component.

For example, the initial implementation will validate:

  • Content-Length is a number
  • Header charset
  • Authority / URI syntax
  • Header name and value format
  • HTTP methods
  • Protocol-specific validations

The goal will be for UHV to replace validations performed by the underlying libraries (http-parser and nghttp2) which will be disabled when Envoy is configured to use UHV (see #19750 and #19751).

@ameily ameily added the triage Issue requires triage label Jan 31, 2022
@ameily ameily changed the title uhv: implement default protocol validations uhv: implement default protocol header validations Jan 31, 2022
@snowp snowp added enhancement Feature requests. Not bugs or questions. and removed triage Issue requires triage labels Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 6, 2022
@yanavlasov yanavlasov added area/http no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels Mar 8, 2022
@ameily ameily changed the title uhv: implement default protocol header validations e May 5, 2022
@ameily ameily changed the title e uhv: implement default protocol header validations May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/http enhancement Feature requests. Not bugs or questions. no stalebot Disables stalebot from closing an issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants