Bad version strings in 1.20.2

[andrewstucki]

Title: Bad version strings in 1.20.2

Description:

What issue is being seen? Describe what should be happening instead of
the bug, for example: Envoy should not crash, the expected value isn't
returned, etc.

Looks like the version strings in the latest release artifacts contain -dev metadata in them.

Repro steps:

Include sample requests, environment, etc. All data and inputs
required to reproduce the bug.

➜  ~ docker run --rm envoyproxy/envoy:v1.20.1 --version

envoy  version: ea23f47b27464794980c05ab290a3b73d801405e/1.20.1/Clean/RELEASE/BoringSSL

➜  ~ docker run --rm envoyproxy/envoy:v1.20.2 --version

envoy  version: 4aaf9593152c6996b9da384c8918e9ad4f0abd4d/1.20.2-dev/Clean/RELEASE/BoringSSL

Notice 1.20.2-dev rather than 1.20.2

[daixiang0]

Not sure it is a wrong push or push code bug.

/cc @phlax

[andrewstucki]

So, looks like in all of the releases yesterday except for 1.21.1 the VERSION file at the top of the repo contains the -dev build label -- not quite sure of the typical release process, but I'm assuming that was an accident.

1.18.6:

envoy/VERSION

Line 1 in a79ca22

1.18.6-dev

1.19.3:

envoy/VERSION

Line 1 in a17cdcd

1.19.3-dev

1.20.2:

envoy/VERSION

Line 1 in 4aaf959

1.20.2-dev

1.21.1:

envoy/VERSION

Line 1 in af50070

1.21.1

[phlax]

cc @RyanTheOptimist - im wondering if we need to update the release docs somewhere to ensure that all versions are correctly bumped

[mattklein123]

This is a known SNAFU during our release process. We have fixed the procedures for future releases. We don't plan on doing a new release just to fix this issue, though perhaps we should do an email announce about it @RyanTheOptimist and then close this issue? WDYT?

[RyanTheOptimist]

@mattklein123 that SGTM. I'll reply to my announcement to explain the issue with the version strings.

[RyanTheOptimist]

I've sent the reply. Sorry for the headache. The procedure should prevent this from happening in the future.