Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws x-ray tracer configuration with hostname #27570

Closed
SPopenko opened this issue May 23, 2023 · 6 comments
Closed

aws x-ray tracer configuration with hostname #27570

SPopenko opened this issue May 23, 2023 · 6 comments
Labels
area/tracing enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@SPopenko
Copy link

SPopenko commented May 23, 2023

Hello guys,
Standard configuration works fine

tracing:
  http:
    name: envoy.tracers.xray
    typed_config:
      "@type": type.googleapis.com/envoy.config.trace.v3.XRayConfig
      segment_name: "Envoy" # You must set this until v1.14 
      daemon_endpoint:
        protocol: UDP
        address: 127.0.0.1
        port_value: 2000
      sampling_rule_manifest:
        filename: /xray_daemon/rules.json

But how to use configuration with a host name like this:

tracing:
  http:
    name: envoy.tracers.xray
    typed_config:
      "@type": type.googleapis.com/envoy.config.trace.v3.XRayConfig
      segment_name: "Envoy" # You must set this until v1.14 
      daemon_endpoint:
        protocol: UDP
        address: xray-service.amazon-cloudwatch.svc.cluster.local
        port_value: 2000
      sampling_rule_manifest:
        filename: /xray_daemon/rules.json

Error that happened with such config in EKS + Istio

warning envoy config gRPC config for type.googleapis.com/envoy.config.listener.v3.Listener rejected: Error adding/updating listener(s) 0.0.0.0_8080: malformed IP address: xray-service.amazon-cloudwatch.svc.cluster.local:2000
0.0.0.0_8443: malformed IP address: xray-service.amazon-cloudwatch.svc.cluster.local:2000

Related to
#10442
aws/aws-app-mesh-roadmap#319

@SPopenko SPopenko added the triage Issue requires triage label May 23, 2023
@suniltheta
Copy link
Contributor

Like called out in aws/aws-app-mesh-roadmap#319 (comment) the only solution is to enhance x-ray extension to send traces to cluster defined in Envoy config.

@wbpcode wbpcode added enhancement Feature requests. Not bugs or questions. area/tracing and removed triage Issue requires triage labels May 24, 2023
@SPopenko
Copy link
Author

One of the possible workaround, if we are building solution in Amazon EKS + Istio could be usage of OpenTelemetry solution.
https://aws-otel.github.io/docs/getting-started/adot-eks-add-on/installation
https://github.com/istio/istio/blob/master/samples/open-telemetry/tracing/README.md

But this for sure pretty long way to go.

@suniltheta
Copy link
Contributor

Is the plan to collect xray traces using otel-collector agent?
Or xray is temp solution, you would eventually like to use OpenTelemetry tracing solution itself?

@SPopenko
Copy link
Author

The first one.
The plan is to use xray inside of EKS cluster with Istio mesh. Both on product workloads (services) and as well report traces from istio ingressgateway (that is based on envoy as well).

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jun 24, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants