Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reclaim NUL byte from HeaderString #6581

Closed
dnoe opened this issue Apr 15, 2019 · 1 comment
Closed

Reclaim NUL byte from HeaderString #6581

dnoe opened this issue Apr 15, 2019 · 1 comment
Assignees
@dnoe
Labels
no stalebot Disables stalebot from closing an issue tech debt
Milestone
1.11.0

Comments

@dnoe
Copy link
Contributor

dnoe commented Apr 15, 2019 •
edited
Loading

Description:
Once all C string style string processing is removed from HeaderString and all functionality has been migrated to absl::string_view, it should be safe to reclaim the NUL byte that currently needs to be stored at the end of the strings. This should be done separately as an independent PR once all blockers are resolved as it is a risky change.

Context:
#6580 must be resolved first.

Action item for CVE-2019-9900
This was referenced Apr 15, 2019
Open
Merged
@mattklein123 mattklein123 added this to the 1.11.0 milestone Apr 15, 2019
@mattklein123 mattklein123 added the no stalebot Disables stalebot from closing an issue label Apr 15, 2019
@mattklein123
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnoe dnoe

Labels
no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
3 participants
@dnoe @mattklein123 @htuch