Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Http2ProtocolOptions.stream_error_on_invalid_http_messaging #9285

Closed
yanavlasov opened this issue Dec 9, 2019 · 4 comments
Closed

Deprecate Http2ProtocolOptions.stream_error_on_invalid_http_messaging #9285

yanavlasov opened this issue Dec 9, 2019 · 4 comments
Labels
area/http enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@yanavlasov
Copy link
Contributor

Title: Deprecate Http2ProtocolOptions.stream_error_on_invalid_http_messaging

Description:
Deprecate Http2ProtocolOptions.stream_error_on_invalid_http_messaging in favor of the mandatory HttpConnectionManager option(s) to ensure that as of now an easily overlooked flag is configured appropriately for the envoy deployment.
@dio dio added area/http enhancement Feature requests. Not bugs or questions. labels Dec 9, 2019
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or other activity occurs. Thank you for your contributions.

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Jan 8, 2020
@stale
Copy link

stale bot commented Jan 15, 2020

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted". Thank you for your contributions.

@stale stale bot closed this as completed Jan 15, 2020
@rulex123 rulex123 mentioned this issue May 7, 2020
Closed
@mattklein123 mattklein123 reopened this May 7, 2020
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label May 7, 2020
@mattklein123 mattklein123 added the help wanted Needs help! label May 7, 2020
@mk46
Copy link
Contributor

mk46 commented Jan 28, 2021

This one is marked as deprecated in

envoy/api/envoy/config/core/v3/protocol.proto

Line 340 in 268b94b

bool stream_error_on_invalid_http_messaging = 12 [deprecated = true];

@yanavlasov
Copy link
Contributor Author

Resolved in #11748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/http enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dio @mattklein123 @yanavlasov @mk46