Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: add checks for type aliases #9840

Open
junr03 opened this issue Jan 27, 2020 · 2 comments
Open

format: add checks for type aliases #9840

junr03 opened this issue Jan 27, 2020 · 2 comments
Labels
area/build beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help!

Comments

@junr03
Copy link
Member

junr03 commented Jan 27, 2020

Description:
Envoy has several conventions around type aliases defined in STYLE.md. Right now these conventions are checked by reviewers. It would be really useful to have the conventions checked in the format CI run.

This could be done with regexes in the check_format.py script, or optimally by extending clang-tidy.
@junr03 junr03 added enhancement Feature requests. Not bugs or questions. help wanted Needs help! beginner Good starter issues! no stalebot Disables stalebot from closing an issue labels Jan 27, 2020
@mattklein123 mattklein123 added area/build and removed no stalebot Disables stalebot from closing an issue labels Jan 27, 2020
@junr03 junr03 mentioned this issue Jan 27, 2020
Merged
@tomocy
Copy link
Contributor

tomocy commented Jun 10, 2020

Is anyone working on this?? If none, I'll tackle this.

@tomocy tomocy mentioned this issue Jun 10, 2020
Closed
@tomocy tomocy mentioned this issue Jun 18, 2020
Closed
@siddharthkhonde
Copy link

hi. is this still open? I can take a look into this as a beginner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build beginner Good starter issues! enhancement Feature requests. Not bugs or questions. help wanted Needs help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

format: add checks for type alias tomocy/envoy
4 participants
@junr03 @mattklein123 @tomocy @siddharthkhonde