-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any roadmap support for srcset attrs? #157
Comments
In the meantime, I just manually added it wherever I needed it using
|
|
Do either one of you have a link to the actual spec from W3C? This is something that would be neat to implement but I don't think it'll happen within the next few weeks. |
The spec won't help a lot because it's written for browser vendors. But these links should be enough to understand how |
I'll search for the spec myself. |
The spec has been defined by the Responsive Issues (formerly Images) Community Group: https://responsiveimages.org/ Here is the spec: https://html.spec.whatwg.org/multipage/embedded-content.html#attr-img-srcset |
If you guys don't need us to parse it and do whatever you want done with it then v2.0.0 will already support this since we have pass through arguments, if you want us to parse the basics like you gave I think it'll get pushed off until I have time to finish reading at least the basic parts of the spec to decide what we should parse. |
It would be great to have named settings (for example It would use
You can look at how the jekyll-picture-tag plugin handles the settings. Unfortunately, this plugin only generates the |
Something like that _shouldn't_ be too hard to do, especially given we have an uncoupled hook system that would allow you to add any number of sizes you want. Right now instead of it being |
Great! I'll be happy to help you with any test you need! |
Fixes #160: Use {% img name.ext magick:crop:value %} Fixes #149: Use {% img name.ext magick:2x %} also 4x, half. Insur #159: Use a hash of the proxies for the image path. Fixes #150: Simply because the new syntax is solidified. This patch introduces the concept of proxies, so that tags can have proxies that manipulate data, the base included proxy is a magick filter that allows you to adjust and manipulate your image but any number of filters can be used. Because an image can be filtered any number of times each proxy that changes an image will trigger a new hash resulting in an entirely uniq image but if you use an image with a filter 20 times it should in theory continue to cache it and only run the proxies once and hold that cache until you either change the proxy attributes or clear the cache.
Shouldn't this issue be closed, as "duplicate" of #172? |
Hulk: ++mark "jekyll-picture-tag" +reference-implementation. |
I'm going to close this in favor of #421 which is probably coming in 3.x. Or at most 3.0.x since @alexey-pelykh has offered to implement the feature if I don't. I need to get with him and draft how we can do this with support for proxies the easiest. |
Support for the img tag's srcset attribute is getting pretty widespread now: http://caniuse.com/#feat=srcset
the syntax is very easy: http://www.webkit.org/demos/srcset/
Is this on the roadmap to be able to supply retina images that the browser decides how/when to load?
The text was updated successfully, but these errors were encountered: