Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definitions for references? #46

Open
jjwtay opened this issue Aug 14, 2020 · 1 comment
Open

Definitions for references? #46

jjwtay opened this issue Aug 14, 2020 · 1 comment

Comments

@jjwtay
Copy link

jjwtay commented Aug 14, 2020

According to:
classTransformer.test.ts

nested classes currently generate ref's pointing at the json-schema definitions field but doesn't auto include the definitions. Is there any plan to include those in the future? Currently I am hand adding them post schemas being generated but would be amazing if they could be added automatically during generation.

@epiphone
Copy link
Owner

Good point. There's no plan to automatically populate definitions, no, but I'd be happy to review a PR if somebody wants to have a go at it. We need to make sure the implementation plays well with how the library interacts with routing-controllers-openapi though: https://github.com/epiphone/routing-controllers-openapi#validation-classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants