Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Multi-Value Splitting with Miscellaneous Artists #580

Open
smooveg1 opened this issue Dec 27, 2024 · 6 comments
Open

Inconsistent Multi-Value Splitting with Miscellaneous Artists #580

smooveg1 opened this issue Dec 27, 2024 · 6 comments
Labels

Comments

@smooveg1
Copy link

Hello, it appears as though LMS is treating commas as a multi-value separator, in particular for miscellaneous artists such as lyricists or performers, even when the delimiter is set to be a semi-colon for all tags.

All are cases where the person's name = <First Last, Jr.>. LMS seems to be properly ignoring any comma within artist and albumartist related tags, and I confirmed the UI uses semi-colon as the separator for all tags. I was hoping to find out if this was the desired behavior and what I could do to ensure these types of name is treated as a single artist.

Thank you!

@epoupon
Copy link
Owner

epoupon commented Dec 27, 2024

Hello!
It is supposed to be the same code to parse all these artists (lyricists, composers, album artists, etc.) but there may be some subtle corner cases.
Thanks for reporting, will check this soon.
Could you send an offending file at [email protected]?

@epoupon
Copy link
Owner

epoupon commented Dec 27, 2024

You can also use the lms-metadata tool to confirm the issue or to have a better picture of what is parsed (don't forget to set the custom delimiters you set in the UI)

@smooveg1
Copy link
Author

  • In Picard, the field in question shows this: performer:guitar [John Goux; Paul Jackson, Jr.]
  • UI is set for all multi-value tags to separate by semi-colon ';'
  • lms-metadata results:

Parsed metadata
....
139898222124808 [debug] [METADATA] Key = 'PERFORMER:GUITAR', value = 'John Goux'
139898222124808 [debug] [METADATA] Key = 'PERFORMER:GUITAR', value = 'Paul Jackson'
139898222124808 [debug] [METADATA] Key = 'PERFORMER:GUITAR', value = ' Jr.'
....

Interesting that the semi-colon delimiter is being honored properly, ignoring the following space when parsing the next performer. However, the parsing based on the comma separator includes the following space in the next parsed value. I sent the offending file to that email address so you should be able to reproduce.

@epoupon
Copy link
Owner

epoupon commented Dec 28, 2024

Thanks for the info and the file!

@smooveg1
Copy link
Author

As a temporary fix I just manually deleted the comma that separates [Last_name, Jr.] in all artist types, that way I don't get any false duplicates between album/track artists and miscellaneous artists with the same name. If tracks get re-tagged through Musicbrainz, it's just a small effort to then manually update my library. Metadata parsing is now operating as expected.

@epoupon
Copy link
Owner

epoupon commented Jan 8, 2025

I will have to dig a bit more but I am afraid it is a bug in taglib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants