Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Keyboard shortcut for adjusting volume #591

Closed
tuukkao opened this issue Jan 14, 2025 · 1 comment
Closed

[Enhancement] Keyboard shortcut for adjusting volume #591

tuukkao opened this issue Jan 14, 2025 · 1 comment
Milestone

Comments

@tuukkao
Copy link
Contributor

tuukkao commented Jan 14, 2025

Having a keyboard shortcut for adjusting LMS's volume in the ui would be handy. I'm blind and using LMS with the keyboard exclusively. While the slider does work a dedicated keyboard shortcut would do the same thing a lot quicker.

Some suggestions on how this could work:

  • ctrl+up/down
  • Adjust in 10 % increments rounding to the closest 10 % if necessary
    • e.g. If the slider is at 14 %, round up to 20 % when increasing the volume and down 10 % when decreasing.

I would be happy to work on a PR if you think this would be useful and at least a somewhat trivial first issue.

Also, thanks for your great work! I use LMS as my almost-daily driver for listening to my music collection and I really appreciate the design choices you've made.

@epoupon
Copy link
Owner

epoupon commented Jan 15, 2025

Hello! Thanks for your feedback.

Indeed this could be done. It should be quite easy to do , as it is only js code (have a look in media player.js, where the keydownevent is handled)
Feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants