Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate keywords that are not allowed to be empty list using conlist #9689

Open
StephanDeHoop opened this issue Jan 9, 2025 · 0 comments
Open
Labels

Comments

@StephanDeHoop
Copy link
Contributor

StephanDeHoop commented Jan 9, 2025

In the EverestConfig we allow required keywords of type list to be empty. This is probably to easy testing, but for user doesn't really make sense. We can't run an optimization if we don't define any controls for which we are optimizing (unless I am missing something), same goes for objective_functions, if we don't specify an objective function what are we optimizing for?

TODO: Refactor this code to enforce required keywords of type list to be non-empty to improve the use of validating the config.yml (as required in actual use cases). This probably also means fixing associated tests that fail because we now require, for example, len(controls) > 0 (e.g., EverestConfig.with_defaults() will need to be changed too).

This relates to the config keywords: controls and objective_functions

@StephanDeHoop StephanDeHoop moved this to Backlog in SCOUT Jan 9, 2025
@sondreso sondreso moved this from Backlog to Todo in SCOUT Jan 14, 2025
@oyvindeide oyvindeide changed the title Refactor EverestConfig Validate keywords that are not allowed to be empty list using conlist Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant