Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascading Font Issue in Mac OS Browsers #560

Open
moberemk opened this issue Aug 13, 2013 · 3 comments
Open

Cascading Font Issue in Mac OS Browsers #560

moberemk opened this issue Aug 13, 2013 · 3 comments

Comments

@moberemk
Copy link

Running some cross-browser tests on the KineticJS display, I found that the default font display on Mac browsers went to what looks like Times New Roman. This isn't really what I wanted; WIndows browsers just used the font which I specified for the tag. To get the proper font display, I had to manually set the font for each text node. I'm not sure if this is a bug, and if it is, a bug for which platform.

That said, quick solution for this that I'd propose would be to use cascaded font styles, and let me set the font on a higher-level element and have lower-level elements default to that unless otherwise declared.

@ericdrowell
Copy link
Owner

This is an interesting idea, although I'm not sure it would fit cleanly into the KineticJS node tree model. I.e., it might be odd to set text properties on a stage or layer node.

@moberemk
Copy link
Author

Maybe it would work better if it weren't so much setting explicit properties as just default values for them to inherit? Alternatively, making the default font pull from whatever the containing tag uses would improve cross-platform consistency.

@ericdrowell
Copy link
Owner

I have a todo item for the next release (v4.6.0) to reinvestigate the text default logic, so I'll definitely keep this in mind when I get there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants