Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull down JB4A-SDK Using CocoaPods #16

Open
ericnograles opened this issue Dec 17, 2017 · 3 comments
Open

Pull down JB4A-SDK Using CocoaPods #16

ericnograles opened this issue Dec 17, 2017 · 3 comments

Comments

@ericnograles
Copy link
Owner

Overview

We currently package the entire binary for JB4ASDK for iOS, which makes this package unreasonably large. Implement a way to pull down JB4ASDK using CocoaPods so it can be pulled down only at install time and facilitate using npm scripts.

@ericnograles ericnograles changed the title Pull down JB4A-SDK Using CocoaPads Pull down JB4A-SDK Using CocoaPods Dec 17, 2017
@ericnograles
Copy link
Owner Author

For reference: facebook/react-native#15460

@ericnograles
Copy link
Owner Author

It looks like the way we want to do it won't work. Even if I have the JB4ASDK dependency defined in a Podfile for this library, there's no way to automatically pull it down nor link the Xcode Workspace to the React Native project automatically. Will need to revisit in the future as RN adds better support for CocoaPods.

@ericnograles
Copy link
Owner Author

Another option here is to create instructions on how to CocoaPod-ify an RN project, add the JB4ASDK dependency, and then finally link this library, but that would be too unwieldy imo.

Maybe a middle ground solution is to add JB4ASDK for iOS as a dependency to this library via GitHub directly, reference a specific tag, and then just reference all the JB4ASDK files in this fashion. That way:

  1. We don't have to package the large JB4ASDK binaries with this NPM package
  2. We can keep in lockstep with SFMC versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant